Re: [patch 01/2] allow gcc4 to control inlining

[Al Viro]

On Wed, Dec 28, 2005 at 12:46:53PM +0100, Ingo Molnar wrote:
> allow gcc4 compilers to decide what to inline and what not - instead
> of the kernel forcing gcc to inline all the time.

> +#define noinline		__attribute__((noinline))
> +#define __always_inline		inline __attribute__((always_inline))
>  #define __must_check 		__attribute__((warn_unused_result))
>  #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)

You seem to be missing the rest of the patch - namely, addition of
always_inline where it is needed now...

Note that we *do* need it in quite a few places.  Anything that relies on
dead code elimination to kill a call of function that doesn't exist
would better be always inlined...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/