Re: [PATCH 2/2] Areca RAID driver (arcmsr) cleanups

From: Matthew Wilcox
Date: Mon Jan 02 2006 - 16:32:09 EST


On Fri, Dec 30, 2005 at 09:21:58PM -0800, Randy.Dunlap wrote:
> /*
> -**********************************************************************************
> -**********************************************************************************
> +***************************************************************************
> +***************************************************************************
> */

I'd be inclined to remove these useless comment blocks altogether ...

> - /* allocate scsi host information (includes out adapter) scsi_host_alloc==scsi_register */
> + /* allocate scsi host information (includes our adapter)
> + * scsi_host_alloc==scsi_register */
> if ((host =
> scsi_host_alloc(&arcmsr_scsi_host_template,
> sizeof(struct ACB))) == 0) {

host = scsi_host_alloc(...)
if (!host) { ...

> ************************************************************
> - ** We do not allow muti ioctls to the driver at the same duration.
> + ** We do not allow multi ioctls to the driver at the same duration.

s/duration/time/. And how do they prevent that?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/