Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers

[Linus Torvalds]

On Mon, 2 Jan 2006, Jan Engelhardt wrote:

> >* Linus Torvalds <torvalds@xxxxxxxx> wrote:
> >
> >> > For example, I add "inline" for static functions which are only called
> >> > from one place.
> >> 
> >> That's actually not a good practice. Two reasons:
> >> 
> >>  - debuggability goes way down. Oops reports give a much nicer call-chain 
> >>    and better locality for uninlined code.
> 
> When I want to debug, I use
> CFLAGS="-O0 -ggdb3 -fno-inline -fno-omit-frame-pointer"
> for that particular file(s). That sure gets good results. Not sure about 
> who wins in the kernel case: always_inline or -fno-inline.

This is totally not relevant.

99% of all bug-reports happen for non-developers. What developers can and 
can not do from a debuggability standpoint is almost totally 
uninteresting: quite often the developers won't even be able to recreate 
the bug, but have to go on the bug report that comes in from the outside.

And yes, some users are willing to recompile the kernel, and try ten 
different versions, and in general are just worth their weight in gold. 
But many people have trouble even reporting the (short) oops details, much 
less follow up on it. 

So it's actually important that the default config is reasonably easy to 
debug from the oops report. Because it may be the only thing you ever get.

So -O0 and -fno-inline simply isn't practical, because they are not an 
option for a normal kernel. 

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/