Re: [PATCHSET] thread_info annotations and fixes

From: Al Viro
Date: Tue Jan 03 2006 - 17:52:39 EST


On Tue, Jan 03, 2006 at 05:41:45PM -0500, James Bottomley wrote:
> As long as this is just wrappering the existing pointers, then that's
> fine, but just in case it matters, I should point out that, at least for
> parisc, the wrappering is incomplete: we have references to the
> thread_info pointer in the task struct via our assembly glue as well (in
> just two places: the smp secondary CPU start and the _switch_to
> implementation).

You and a _lot_ of other architectures. That's fine - nobody suggests
centrally forced changes of data structure layouts, etc. These decisions
belong to architecture and assembler code is obviously supposed to be
aware of WTF it is doing; such annotations belong on C side of things.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/