Re: [Patch 6/6] Delay accounting: Connector interface

From: Greg KH
Date: Tue Jan 03 2006 - 19:50:28 EST


On Wed, Jan 04, 2006 at 12:42:36AM +0000, Shailabh Nagar wrote:
> Greg KH wrote:
> > On Tue, Jan 03, 2006 at 11:33:40PM +0000, Shailabh Nagar wrote:
> >
> >>Changes since 11/14/05:
> >>
> >>- explicit versioning of statistics data returned
> >>- new command type for returning per-tgid stats
> >>- for cpu running time, use tsk->sched_info.cpu_time (collected by schedstats)
> >>
> >>First post 11/14/05
> >>
> >>delayacct-connector.patch
> >>
> >>Creates a connector interface for getting delay and cpu statistics of tasks
> >>during their lifetime and when they exit. The cpu stats are available only if
> >>CONFIG_SCHEDSTATS is enabled.
> >
> >
> > Why do you use this when we can send typesafe data through netlink
> > messages now?
>
> AFAIK, adding new netlink types was frowned upon which is one of the reasons why
> connectors were proposed (besides making it easier to use the netlink interface) ?

I don't know about the issue of creating new types (have you tried?),
but there is a new netlink message format that pretty should make it
just as easy as the connector stuff to send complex message types.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/