Re: [PATCH] fix warning in 8250.c

[Russell King]

On Tue, Jan 03, 2006 at 10:12:48AM +0200, Denis Vlasenko wrote:
>   CC      drivers/serial/8250.o
> /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: 'transmit_chars' declared inline after being called
> /.1/usr/srcdevel/kernel/linux-2.6.15-rc7.src/drivers/serial/8250.c:1085: warning: previous declaration of 'transmit_chars' was here
> 
> Since this function is not small, inlining effect is way below noise floor.
> Let's just remove _INLINE_.

I think we want to remove _INLINE_ from both receive_chars and
transmit_chars.  Both functions aren't small, so...

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/