Re: [PATCH] fix warning in 8250.c

From: Andrew Morton
Date: Wed Jan 04 2006 - 18:48:54 EST


Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
>
> > While we're at it can we please kill _INLINE_? Those functions that should
> > be inlined can become inline, but this macro just obsfucates the serial code.
>
> No idea - I don't know about x86 nuances and why they wanted:
>
> #if defined(__i386__) && (defined(CONFIG_M386) || defined(CONFIG_M486))
> #define _INLINE_ inline
> #else
> #define _INLINE_
> #endif
>
> Maybe someone in the x86 world needs to comment? Does the above even
> mean that we'll ever inline anything marked _INLINE_ ?

I suspect the reasoning behind this is lost in the mists of pre-bk time.
I'd be inclined to just nuke it and see what happens. Nothing, I expect.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/