Re: [patch 2.6.15] i386: Optimize local APIC timer interrupt code

[Chuck Ebbert]

In-Reply-To: <20060105060314.GB7142@xxxxxxxxx>

On Thu, 5 Jan 2006 at 07:03:14 +0100, Willy Tarreau wrote:

> +     if (likely(--per_cpu(prof_counter, cpu)) <= 0) {
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
are you sure about this ? it looks suspicious to me. I would have
expected something like  this instead :

+       if (likely(--per_cpu(prof_counter, cpu) <= 0)) {


  Nice catch, proving yet again the value of posting code for review!


-- 
Chuck
Currently reading: _Thud!_ by Terry Pratchett
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/