Re: [PATCH] Shrinks sizeof(files_struct) and better layout

[David Lang]

On Wed, 4 Jan 2006, Eric Dumazet wrote:

> Date: Wed, 04 Jan 2006 12:13:25 +0100
> From: Eric Dumazet <dada1@xxxxxxxxxxxxx>
> To: Andi Kleen <ak@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Shrinks sizeof(files_struct) and better layout
>
> Andi Kleen a écrit :
> > Eric Dumazet <dada1@xxxxxxxxxxxxx> writes:
> > > 1) Reduces the size of (struct fdtable) to exactly 64 bytes on 32bits
> > > platforms, lowering kmalloc() allocated space by 50%.
> >
> > It should be probably a kmem_cache_alloc() instead of a kmalloc
> > in the first place anyways. This would reduce fragmentation.
>
> Well in theory yes, if you really expect thousand of tasks running...
> But for most machines, number of concurrent tasks is < 200, and using a 
> special cache for this is not a win.

is it enough of a win on machines with thousands of concurrent tasks that 
it would be a useful config option?

David Lang

--
There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies. And the other way is to make it so complicated that there are no obvious deficiencies.
 -- C.A.R. Hoare

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/