Re: [PATCH] kernelrelase only recomputed when necessary

[Linus Torvalds]

On Sun, 8 Jan 2006, Sam Ravnborg wrote:
>
> This patch goes on top of patch from hpa titled:
> Drop vmlinux dependency from "make install"

This part looks bogus:

> diff --git a/arch/x86_64/Makefile b/arch/x86_64/Makefile
> index a9cd42e..663dbdb 100644
> --- a/arch/x86_64/Makefile
> +++ b/arch/x86_64/Makefile
> @@ -80,7 +80,7 @@ bzlilo: vmlinux
>  bzdisk: vmlinux
>  	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) zdisk
>  
> -install fdimage fdimage144 fdimage288: vmlinux
> +install fdimage fdimage144 fdimage288:
>  	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) $@
>  
>  archclean:


That rule should probably be:

	fdimage fdimage144 fdimage288: vmlinux
	install:
		$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(BOOTIMAGE) $@

since the fdimages should still depend on vmlinux.

No?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/