Re: [PATCH] ia64: including <asm/signal.h> alone causes compilationerrors

From: Jeff Mahoney
Date: Mon Jan 09 2006 - 12:37:44 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Wilcox wrote:
> On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote:
>> +++ linux-2.6.15-ocfs2/include/asm-ia64/signal.h 2006-01-09 11:08:16.404700640 -0500
>> @@ -1,6 +1,8 @@
>> #ifndef _ASM_IA64_SIGNAL_H
>> #define _ASM_IA64_SIGNAL_H
>>
>> +#include <linux/types.h>
>> +
>> /*
>> * Modified 1998-2001, 2003
>> * David Mosberger-Tang <davidm@xxxxxxxxxx>, Hewlett-Packard Co
>> @@ -122,8 +124,6 @@
>>
>> # ifndef __ASSEMBLY__
>>
>> -# include <linux/types.h>
>> -
>> /* Avoid too many header ordering problems. */
>> struct siginfo;
>
> Is it still possible to include this file from assembly? Do we still
> need to do that?
>
>

Yes, actually, it is. :(

Christoph also pointed out that including <linux/signal.h> is the better
solution, so I'm submitting that patch to the OCFS2 folks instead.

Sorry for the noise.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDwqCjLPWxlyuTD7IRAj8PAJwLv2EghfMR9yPuaVhpTLQMGysKpwCfcVBq
7ZT0LwuYEjKYVnJT/QeXmCw=
=Yt8o
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/