Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32

From: Bryan O'Sullivan
Date: Tue Jan 10 2006 - 12:53:53 EST


On Tue, 2006-01-10 at 17:51 +0000, Christoph Hellwig wrote:

> This should be in the implementation file, not near the prototype.
> And needs to start with /** to be valid kernel doc.

OK, thanks.

> > +void __raw_memcpy_toio32(void __iomem *to, const void *from, size_t count);
>
> and without that comment I'd suggest just adding this to every asm/io.h
> instead of an asm-generic header for just one prototype.

OK, that header file will vanish.

<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/