Re: [PATCH 4/5] rcu: join rcu_ctrlblk and rcu_state

[Dipankar Sarma]

On Mon, Jan 09, 2006 at 04:28:18PM -0800, Paul E. McKenney wrote:
> On Sun, Jan 08, 2006 at 10:19:42PM +0300, Oleg Nesterov wrote:
> > This patch moves rcu_state into the rcu_ctrlblk. I think there
> > are no reasons why we should have 2 different variables to control
> > rcu state. Every user of rcu_state has also "rcu_ctrlblk *rcp" in
> > the parameter list.
> 
> This patch looks sane to me.  It passes a short one-hour rcutorture
> on ppc64 and x86, firing up some overnight runs as well.
> 
> Dipankar, Manfred, any other concerns?  Cacheline alignment?  (Seems
> to me this code is far enough from the fastpath that this should not
> be a problem, but thought I should ask.)
> 

rcu_state came over from Manfred's RCU_HUGE patch IIRC. I don't
think it is necessary to allocate rcu_state separately in the
current mainline RCU code. So, the patch looks OK to me, but
Manfred might see something that I am not seeing.

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/