Re: [PATCH 1 of 3] Introduce __raw_memcpy_toio32

From: Andrew Morton
Date: Tue Jan 10 2006 - 18:30:01 EST


"Bryan O'Sullivan" <bos@xxxxxxxxxxxxx> wrote:
>
> On Tue, 2006-01-10 at 14:05 -0800, Andrew Morton wrote:
>
> > It's kinda fun playing Brian along like this ;)
>
> A regular barrel of monkeys, indeed...
>
> > One option is to just stick the thing in an existing lib/ or kernel/ file
> > and mark it __attribute__((weak)). That way architectures can override it
> > for free with no ifdefs, no Makefile trickery, no Kconfig trickery, etc.
>
> I'm easy. Would you prefer to take that, or the Kconfig-trickery-based
> patch series I already posted earlier?
>

Unless someone can think of a problem with attribute(weak), I think you'll
find that it's the simplest-by-far solution.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/