Re: [patch 1/5] Add MMC password protection (lock/unlock) support V3

[Russell King]

On Wed, Jan 11, 2006 at 09:16:28AM -0400, Anderson Briglia wrote:
> Russell King wrote:
> 
> >On Mon, Jan 09, 2006 at 06:15:00PM -0400, Anderson Briglia wrote:
> >  
> >
> >>When a card is locked, only commands from the "basic" and "lock card" classes
> >>are accepted. To be able to use the other commands, the card must be unlocked
> >>first.
> >>    
> >>
> >
> >I don't think this works as you intend.
> >
> >When a card is initially inserted, we discover the cards via mmc_setup()
> >and mmc_discover_cards().  This means that we'll never set the locked
> >status for newly inserted cards.
> >  
> >
> mmc_setup() calls mmc_check_cards(). Our patch adds the necessary code
> to mmc_check_cards() to set the locked state when the card is locked.

Not in Linus' kernel, it doesn't.

If you're working off the OMAP tree, bear in mind that I've found in
the past that they have a large number of wrong or inappropriate
changes to the MMC layer in there.  They don't regularly merge either,
and they certainly don't forward any bug fixes for review in a timely
manner.

mmc_rescan() is the only caller of mmc_check_cards(), and this only
happens if mmc_rescan() is called with the power already applied
(iow, cards are already known to the MMC layer.)

This call is done _before_ we call mmc_setup() to discover new cards.

Calling mmc_check_cards() from mmc_rescan() is _wrong_, and from what
I can ascertain, it's probably due to unforwarded broken changes in
the OMAP tree.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/