Re: [PATCH 3 of 3] Add __raw_memcpy_toio32 to each arch

From: Andrew Morton
Date: Wed Jan 11 2006 - 19:12:56 EST


"Bryan O'Sullivan" <bos@xxxxxxxxxxxxx> wrote:
>
> On Wed, 2006-01-11 at 15:46 -0800, Andrew Morton wrote:
>
> > How's about we add a new linux/io.h which does:
> >
> > #include <asm/io.h>
> > void __raw_memcpy_toio32(void __iomem *to, const void *from, size_t count);
>
> I thought about this, and about moving other duplicated definitions from
> asm-*/io.h in here, but I couldn't find any other obvious candidates, so
> I wasn't anxious to introduce a new file.
>

Well it's obviously better than duplicating the thing.

There are other common things which can be hoisted to linux/io.h, but if we
do that then zillions of .c files need to be changed to include linux/io.h
rather than asm/io.h. That's a good janitorial thing to do, but I doubt if
you want to do it ;)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/