Re: [PATCH 12/17] fuse: add connection aborting

[Andrew Morton]

Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
>  	unsigned mounted : 1;
>  	unsigned connected : 1;

Do these bitfields have locking?

On some architectures, it might be that

	foo->mounted = 1;

will race with another CPU doing

	bar->connected = 1;

if the CPU+compiler implements bitfield modification via non-atomic
read/modify/write.

I don't know whether that's happening in real life, but it's a subtle risk.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/