Re: [PATCH] INPUT: add MODALIAS to the event environment

[Kay Sievers]

On Sat, Jan 14, 2006 at 06:15:14PM +0500, Alexander E. Patrakov wrote:
> Kay Sievers wrote:
> >On Sat, Jan 14, 2006 at 10:14:00AM +0500, Alexander E. Patrakov wrote:
> >>Greg KH wrote:
> >>
> >>>[PATCH] INPUT: add MODALIAS to the event environment
> >>>
> >>>input: add MODALIAS to the event environment
> >>>
> >>Could you please tell me sample modaliases for a number of "common" 
> >>devices (like a PS/2 mouse)?
> >>
> >>I ask because earlier (namely, in 
> >>http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/old/gregkh-all-2.6.15.patch) 
> >>such modaliases contained commas (",") and comma is not a "trusted" 
> >>character in Udev (see replace_untrusted_chars() in udev_utils_string.c). 
> >>Thus, such modaliases were mangled and didn't work.
> >
> >Only if you read it with $sysfs{modalias}, it's available in $env{MODALIAS}
> >and does not get mangled there, right? If you have problems with that,
> >let us know and we will fix it.
> > 
> >
> With the old gregkh-all-2.6.15.patch, I have:
> 
> sh-3.1# cat /sys/class/input/input1/modalias
> input:b0011v0002p0004e0000-e0,1,2,k110,111,112,113,114,r0,1,8,amlsfw

> i.e., there is the "modalias" file in sysfs but no $MODALIAS in the 
> environment. Is this the problem that your patch solves (note: I haven't 
> tried it yet)?

Well, you could have read the mail's subject, before posting.

Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/