Re: [patch 2.6.15-mm4] sem2mutex: infiniband, #2

From: Anton Blanchard
Date: Sat Jan 14 2006 - 21:00:23 EST



Hi Ingo,

Just a small thing, it looks like the script is doing a double include
of linux/mutex.h a few times:

> Index: linux/drivers/infiniband/hw/mthca/mthca_dev.h
> ===================================================================
> --- linux.orig/drivers/infiniband/hw/mthca/mthca_dev.h
> +++ linux/drivers/infiniband/hw/mthca/mthca_dev.h
> @@ -44,7 +44,9 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/timer.h>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
> +#include <linux/mutex.h>
> +
>
> #include "mthca_provider.h"
> #include "mthca_doorbell.h"

...

> Index: linux/drivers/infiniband/hw/mthca/mthca_memfree.h
> ===================================================================
> --- linux.orig/drivers/infiniband/hw/mthca/mthca_memfree.h
> +++ linux/drivers/infiniband/hw/mthca/mthca_memfree.h
> @@ -40,7 +40,9 @@
> #include <linux/list.h>
> #include <linux/pci.h>
>
> -#include <asm/semaphore.h>
> +#include <linux/mutex.h>
> +#include <linux/mutex.h>
> +
>
> #define MTHCA_ICM_CHUNK_LEN \
> ((256 - sizeof (struct list_head) - 2 * sizeof (int)) / \

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/