Re: PATCH: SBC EPX does not check/claim I/O ports it uses

From: Bartlomiej Zolnierkiewicz
Date: Tue Jan 17 2006 - 13:02:53 EST


Hi,

> @@ -180,6 +181,9 @@
> static int __init watchdog_init(void)
> {
> int ret;
> +
> + if (!request_region(EPXC3_WATCHDOG_CTL_REG, 2, "epxc3_watchdog"))
> + return -EBUSY;
>
> ret = register_reboot_notifier(&epx_c3_notifier);
> if (ret) {

Shouldn't resource be released when
register_reboot_notifier() or misc_register() fails?

Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/