Re: [PATCH] Busy inodes after unmount, be more verbose ingeneric_shutdown_super

From: Andrew Morton
Date: Wed Jan 18 2006 - 18:10:20 EST


Jan Blunck <jblunck@xxxxxxx> wrote:
>
> On Tue, Jan 17, Kirill Korotaev wrote:
>
> > Olaf, can you please check if my patch for busy inodes from -mm tree
> > helps you?
> > Patch name is fix-of-dcache-race-leading-to-busy-inodes-on-umount.patch
> > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.15/2.6.15-mm4/broken-out/fix-of-dcache-race-leading-to-busy-inodes-on-umount.patch
>
> This patch is just wrong. It is hiding bugs in file systems. The problem is
> that somewhere the reference counting on the vfsmount objects is wrong. The
> file system is unmounted before the last dentry is dereferenced. Either you
> didn't hold a reference to the proper vfsmount objects at all or you
> dereference it too early. See Al Viros patch series (search for "namei fixes")
> on how to fix this issues.
>

The only reason I've been carrying that patch is as a reminder that there's
a bug that we need to fix. It'd be good news if that bug had been fixed by
other means.

Kirill, do you know whether the bug is still present in 2.6.16-rc1?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/