Re: [patch 1/2] x86_64: pageattr use single list

[Nick Piggin]

On Wed, Jan 18, 2006 at 02:38:11PM -0500, Jason Baron wrote:
> 
> On Wed, 18 Jan 2006, Nick Piggin wrote:
> 
> > Use page->lru.next to implement the singly linked list of pages rather
> > than the struct deferred_page which needs to be allocated and freed for
> > each page.
> > 
> > Signed-off-by: Nick Piggin <npiggin@xxxxxxx>
> > Acked-by: Andi Kleen <ak@xxxxxxx>
> > 
> > Index: linux-2.6/arch/x86_64/mm/pageattr.c
> > ===================================================================
> 
> ...
> 
> > +
> > +	flush_map((dpage && !dpage->lru.next) ? (unsigned long)page_address(dpage) : 0);
> > +	while (dpage) {
> > +		__free_page(dpage);
> > +		dpage = (struct page *)dpage->lru.next;
> >  	} 
> >  } 
> >  
> 
> do you want to be touching a struct page that was just freed?
> 

No, thanks. Good catch.

Nick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/