Re: [PATCH RT] don't let printk unconditionally turn on interrupts

From: Ingo Molnar
Date: Sat Jan 21 2006 - 05:26:23 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> Ingo,
>
> My first try at booting -rt8 on my machine crashed immediately. No
> nmi, no nothing. Just a lockup at the registration of the ACPI_PM
> timer. This would happen every time, and after struggling for a while,
> I finally found out why!
>
> The printk in timeofday_periodic_hook that is called holding the
> write_lock of system_time_lock (a raw_seq_lock) was causing lots of
> havoc. The printk would turn on interrupts, and then I would get a
> deadlock when the interrupt would do a read on system_time_lock.

argh. This piece of code has caused so many problems already. Some
people want console drivers to be preemptible, but i guess being able to
boot trumps things ;)

could you check out the variant in 2.6.15-rt11 - i tweaked it slightly
over yours, hopefully making the behavior more consistent.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/