Re: [PATCH 2/9] device-mapper log bitset: fix endian

[Andrew Morton]

Alasdair G Kergon <agk@xxxxxxxxxx> wrote:
>
>  -	set_bit(bit, (unsigned long *) bs);
>  +	ext2_set_bit(bit, (unsigned long *) bs);

We really should give those things a more appropriate name.

ext2_set_bit() is non-atomic, so the above code must provide its own
locking against other CPUs (and threads, if preempt) performing
modification of this memory.

Is such locking present?  If not, we should use ext2_set_bit_atomic(). 
(And if so, the old code could have used __set_bit)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/