Re: [PATCH] garbage values in file /proc/net/sockstat

[Andi Kleen]

On Monday 23 January 2006 12:21, pravin shelar wrote:
> 	In 2.6.16-rc1-mm1, (for x86_64 arch) cpu_possible_map is not same 
> as NR_CPUS (prefill_possible_map()). Therefore per cpu areas are allocated 
> for cpu_possible cpus only (setup_per_cpu_areas()). This causes sockstat 
> to return garbage value on x84_64 arch.
> 
> So these per_cpu accesses are geting relocated (RELOC_HIDE) using
> boot_cpu_pda[]->data_offset which is not initialized.
> 
> There are other instances of same bug where per_cpu() macro is used
> without cpu_possible() check. e.g. net/core/utils.c :: 
> net_random_reseed(), net/core/dev.c :: net_dev_init(), etc.
> 
> This patch fixes these bugs.

Thanks. Patches Look good.  Dave, can you push them for 2.6.16 still please?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/