Re: [PATCH] shrink_dcache_parent() races against shrink_dcache_memory()

From: Kirill Korotaev
Date: Mon Jan 30 2006 - 10:55:31 EST


Hello Jan,


this is much cleaner now and looks more like my original patch and is smaller/more beautifull with counters usage. Thanks.


Yes, it is heavily inspired by you patch.
thanks again. BTW, out of curiosity why do you work on this?

However, with counters instead of list it is possible to create a live lock :( So I'm not sure it is really ok.


Hmm, I don't really get what you mean with "live lock".
By "live lock" I mean the situation when you are "locked" in shrink_dcache_parent() due to wait_on_prunes() always returns 1.
We used shrinker list with a reference to dentry specially to avoid this as much as possible. I'm not sure how real such live lock can be created, but I can think it over.

BTW, what kernel is it for? 2.6.15 or 2.6.16-X?


http://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git from
today.
thanks!

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/