Re: [patch -mm4] i386: __init should be __cpuinit

From: Ashok Raj
Date: Wed Feb 01 2006 - 14:15:15 EST


On Wed, Feb 01, 2006 at 06:56:22PM +0000, Alan Cox wrote:
> On Mer, 2006-02-01 at 11:03 -0500, Dave Jones wrote:
> > > For SMP systems, suspend/resume "unplugs" all non-boot CPUs before
> > > executing the suspend code. I don't recall any SMP cyrix systems, but
> > > it's potentially something to consider.
> >
> > There weren't any. Until AMD's Athlon MPs, Intel had the only
> > SMP x86 afair.
>
> Several vendors demonstrated OpenMP designs including Cyrix. Nothing
> production and nothing we support.

In order to support logical cpu hotplug, you dont need any special hw, as long
as you has some SMP box. Sometimes its just a little bit more than
moving __init to __cpuinit. A lot of these references were not changed
just speculatively to ensure when the need is there, someone will change and
test those as well.

Chuck, would it be possible for you also test cpu hotplug for the ones you
are interested in and accompany the related changes if there are more
as separate patches? (Documentation now has a howto on cpu hotplug)

That would make it more useful for this exersise.

--
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/