Re: [PATCH] SIIG 8-port serial boards support

From: Russell King
Date: Fri Feb 03 2006 - 04:22:48 EST


On Fri, Feb 03, 2006 at 12:13:08PM +0300, Andrey Panin wrote:
> On 033, 02 02, 2006 at 08:17:35 +0000, Russell King wrote:
> > As I've said many a time, we need a generic way to set different hand-
> > shaking modes. I've suggested using some spare bits in termios in the
> > past, but nothing ever came of that - folk lose interest at that point.
>
> IMHO there is no need to userspace visible changes to support RS485 on
> these cards, because some of them are RS485 only and some have jumpers
> for individual ports. There is nothing that userspace can configure.
> We only need to set two bits in ACR according to card type and jumper
> settings and UART will drive RS485 transiever transparently.

In this particular case you may be right, but I'm looking at the bigger
picture, where plain 16550's may be used for RS485.

There are drivers which want to implement their own private ioctl to
enable RS485 mode. What I'm saying is that we should have one solution,
not multiple solutions to this problem. When we have such a solution,
your RS485 card will be able to fit into that model.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/