Re: [PATCH 3/5] cpuset memory spread slab cache implementation

[Christoph Lameter]

On Sat, 4 Feb 2006, Andrew Morton wrote:

> Paul Jackson <pj@xxxxxxx> wrote:
> >
> > +	if (unlikely(cpuset_mem_spread_check() &&
> >  +					(cachep->flags & SLAB_MEM_SPREAD) &&
> >  +					!in_interrupt())) {
> >  +		int nid = cpuset_mem_spread_node();
> >  +
> >  +		if (nid != numa_node_id())
> >  +			return __cache_alloc_node(cachep, flags, nid);
> >  +	}
> 
> Need a comment here explaining the mysterious !in_interrupt() check.

If we are in interrupt context then the current pointer may not be 
meaningful. cpuset settings should not be applied for any memory 
allocation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/