Re: [v4l-dvb-maintainer] [2.6 patch] drivers/media/dvb/frontends/mt312.c: possible cleanups

[Johannes Stezenbach]

On Sun, Feb 05, 2006, Michael Krufky wrote:
> Adrian Bunk wrote:
> >+	if (state->id == ID_VP310){

lacks a space

> >-EXPORT_SYMBOL(mt312_attach);
> >-EXPORT_SYMBOL(vp310_attach);
> >+EXPORT_SYMBOL(vp310_mt312_attach);
> 
> ^^^ I think vp310_mt312_attach is starting to get long, maybe even ugly. 
>  Isn't mt312_attach enough, considering that it is the name of the 
> module?  I think just mt312_attach would be nicer, unless someone thinks 
> otherwise?
...
> >-	if ((fc->fe = vp310_attach(&skystar23_samsung_tbdu18132_config, 
> >&fc->i2c_adap)) != NULL) {
> >+	if ((fc->fe = 
> >vp310_mt312_attach(&skystar23_samsung_tbdu18132_config, &fc->i2c_adap)) != 
> >NULL) {

mt312_attach() isn't used by any driver, so it looks like a bad choice
for a name. IMHO vp310_mt312_attach() is fine.


Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/