Re: [PATCH] Fix build failure in recent pm_prepare_* changes.

From: Dave Jones
Date: Sun Feb 05 2006 - 14:01:39 EST


On Sun, Feb 05, 2006 at 01:56:10PM +0100, Olaf Hering wrote:
> On Fri, Feb 03, Linux Kernel Mailing List wrote:
>
> > tree 8f70444139c8564c0f1e88e1f33adda036ae6a96
> > parent 278ff9537030bbb292b33504f5e1f6e0126793eb
> > author Dave Jones <davej@xxxxxxxxxx> Fri, 03 Feb 2006 19:03:44 -0800
> > committer Linus Torvalds <torvalds@xxxxxxxxxxx> Sat, 04 Feb 2006 00:32:00 -0800
> >
> > [PATCH] Fix build failure in recent pm_prepare_* changes.
> >
> > kernel/power/power.h:49: error: static declaration of 'pm_prepare_console' follows non-static declaration
> > include/linux/suspend.h:46: error: previous declaration of 'pm_prepare_console' was here
> > kernel/power/power.h:50: error: static declaration of 'pm_restore_console' follows non-static declaration
> > include/linux/suspend.h:47: error: previous declaration of 'pm_restore_console' was here
> >
> > Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> this one is not correct, please have a closer look at
> f7b8988ff50d99c99746f65f420364e91362c065
>
> CC drivers/macintosh/via-pmu.o
> drivers/macintosh/via-pmu.c: In function 'pmac_suspend_devices':
> drivers/macintosh/via-pmu.c:2078: error: implicit declaration of function 'pm_prepare_console'
> drivers/macintosh/via-pmu.c: In function 'pmac_wakeup_devices':
> drivers/macintosh/via-pmu.c:2194: error: implicit declaration of function 'pm_restore_console'
> make[2]: *** [drivers/macintosh/via-pmu.o] Error 1

Strange, my ppc[64] builds compiled and linked without failure. I think perhaps
it's time I added -Werror-implicit-function-declaration to the Makefile.

I'll not get a chance to look into fixing this until tomorrow, so if Rafael/Pavel
have time before then, maybe they'll beat me to it.


Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/