Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit - Resubmit

[Alon Bar-Lev]

Hello,

Since I removed this from the main text:

>-The kernel command line is a null-terminated string currently up to
>-255 characters long, plus the final null.  A string that is too long
>-will be automatically truncated by the kernel, a boot loader may allow
>-a longer command line to be passed to permit future kernels to extend
>-this limit.
>+The kernel command line is a null-terminated string. A string that is too
>+long will be automatically truncated by the kernel.

I thought it would be appropriate to add it to the older (<2.02) boot
protocols specific notes.

>+       The kernel command line *must* be 256 bytes including the
>+       final null.

I've removed the 256 limit from the 2.02 boot protocol since grub and
lilo guys did not understand the comment: "a boot loader may allow a
longer command line to be passed to permit future kernels to extend
this limit.", they both truncate the command-line to 256 (hard coded).
I thought that it best to make clear that the limit on the
command-line length is determined by the kernel and not by the boot
loader.

I can remove the addition.

Best Regards,
Alon Bar-Lev

On 2/6/06, Randy.Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> On Fri, 03 Feb 2006 22:32:29 +0200 Alon Bar-Lev wrote:
>
> >
> > Extending the kernel parameters to a size of 1024 on boot
> > protocol >=2.02 for i386 and x86_64 architectures.
> >
> > Signed-off-by: Alon Bar-Lev <alon.barlev@xxxxxxxxx>
> >
> > ---
> >
> > Hello,
> >
> > This patch was submitted a long ago, but did not find its
> > way into the kernel, but was not rejected as well.
> >
> > Current implementation allows the kernel to receive up to
> > 255 characters from the bootloader.
> >
> > In current environment, the command-line is used in order to
> > specify many values, including suspend/resume, module
> > arguments, splash, initramfs and more.
> >
> > 255 characters are not enough anymore.
> >
> > Please consider to merge.
>
> Please explain this comment and why it is being added:
>
> +       The kernel command line *must* be 256 bytes including the
> +       final null.
> +
>
> thanks,
> ---
> ~Randy
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/