Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME
From: Kirill Korotaev
Date: Mon Feb 06 2006 - 03:50:07 EST
I am disturbed by the introduction of #defines like current_vps() andIt is not magic defines, this is done intentionally.
Magic lower case #defines are usually a bad idea.
You can take a more detailed view into OpenVZ sources, but the idea is
to make kernel compilable without virtualization.
When virtualization is OFF all this macros are defined to trivial
variables/defines which make it an old good kernel.
For example current_vps() should be (&init_vps), i.e. host system
vps_utsname will be defined as system_utsname and so on.
These defines hide the cost of the operations you are performing.You mean to have variable and define with the same names?
At that point you might as well name the thing system_utsname
so you don't have to change the code.
it is not always good. It works fine, when both are defined in the same
file, but poorly when it is scattered all around...
And of course you failed to change several references towhich one? Maybe intentionally? ;-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/