[patch] swsusp: kill unneeded/unbalanced bio_get (try 2)

From: Pavel Machek
Date: Tue Feb 07 2006 - 04:42:33 EST



I messed the first attempt up, it only moved leak to error path. Could
you replace it with this?

---

Takashi pointed out that I don't bio_put in non-error cases, and says
bio_get is not neccessary. It still works so I hope he's ok.

Signed-off-by: Pavel Machek <pavel@xxxxxxx>

diff --git a/kernel/power/swsusp.c b/kernel/power/swsusp.c
index 59c91c1..c91275e 100644
--- a/kernel/power/swsusp.c
+++ b/kernel/power/swsusp.c
@@ -743,7 +743,6 @@ static int submit(int rw, pgoff_t page_o
if (!bio)
return -ENOMEM;
bio->bi_sector = page_off * (PAGE_SIZE >> 9);
- bio_get(bio);
bio->bi_bdev = resume_bdev;
bio->bi_end_io = end_io;



--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/