Re: Terminate process that fails on a constrained allocation

[Andrew Morton]

Christoph Lameter <clameter@xxxxxxxxxxxx> wrote:
>
> On Wed, 8 Feb 2006, Andrew Morton wrote:
> 
> > > I think it should be put into 2.6.16. Andrew?
> > 
> > Does every single caller of __alloc_pages(__GFP_FS) correctly handle a NULL
> > return?  I doubt it, in which case this patch will cause oopses and hangs.
> 
> If a caller cannot handle NULL then __GFP_NOFAIL has to be set, right?

That would assume non-buggy code.  I'm talking about the exercising of
hitherto-unused codepaths.  We've fixed many, many pieces of code which
simply assumed that kmalloc(GFP_KERNEL) succeeds.  I doubt if many such
simple bugs still exist, but there will be more subtle ones in there.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/