Commit validation/assurance; change control...

From: Linda Walsh
Date: Wed Feb 08 2006 - 20:24:17 EST

Randy.Dunlap wrote:
Linda, did you have some other point that you are trying to get to,
or is that it? There are real efforts being made, although not
perfect. That happens when people are involved.
It depends on what tools you use to verify input. How many
commits don't "compile"? There are people involved in
that effort, but that doesn't mean we accept C-syntax
errors as being inevitable does it?

If something doesn't compile, isn't it expected that the author
will fix it before it becomes part of the mainline code?

Commit meta-information can as easily be verified for basic
"syntax" (field presence). If a commit is missing basic
information, it could be bounced back to the submitter to be
fixed before being accepted into the mainline tree.

No more perfection is required than is already accepted for C-source
files: if they don't compile, fix them. There's no discussions
about people making an "effort" to have kernel releases that compile.
They either do, or don't (ignoring vagaries of untested platform,
Config options or compiler differences).

Anyway, it feels like you are just getting to the surface/edge
of your complaint.
Complaint is a bit stronger than I meant. You could take it
as a report of a new "commit" that doesn't compile correctly. That's
not usually a complaint in a development environment -- that's
part of the development, test and fix cycle.

I'm just trying to, programatically, read in the Changes file so
I can, perhaps, sort them by by some criteria. I ran into "syntax"
errors in the Change-log regarding missing fields. This is a an
_inquiry_ into what meta-information "should" be included with a commit:
What is expected? What is required? What is desired?

I'm not expecting the current version of the change log to be "fixed",
but if we have no measure or feedback regarding how well we are
adhering to *whatever* standard is "agreed" (or mandated), how can
we know if we are know if we are "there" yet?

Someday, maybe the 1-line descriptions could be complete enough for
automatic parsing & sorting so someone could look choose to look
at changes in a particular subsystem, driver or architecture. But
that level of 'semantic' validity is a bit beyond simple
"commit" meta-info syntax checking. ;-)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at