pktcdvd stack usage regression

From: Adrian Bunk
Date: Wed Feb 08 2006 - 21:08:32 EST

Hi Phillip,

your recent patch "pktcdvd: Allow larger packets" changed
PACKET_MAX_SIZE in the pktcdvd driver from 32 to 128.

Unfortunately, drivers/block/pktcdvd.c contains the following:

<-- snip -->

static void pkt_start_write(struct pktcdvd_device *pd, struct
packet_data *pkt)
struct bio *bio;
struct page *pages[PACKET_MAX_SIZE];
int offsets[PACKET_MAX_SIZE];

<-- snip -->

With PACKET_MAX_SIZE=128, this allocates more than 1 kB on the stack
which is not acceptable considering that we might have only 4 kB stack

Please either fix this before 2.6.16 or ask Linus to revert commit



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at