Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation,removed unneeded return

[Pete Zaitcev]

On Wed, 8 Feb 2006 10:29:15 +0100, Marc Koschewski <marc@xxxxxxxxxxxxxxx> wrote:

> I created this little patch while reading through drivers/block/ub.c. It fixes
> some indentation/whitespace as well as some empty commenting, an hardcoded
> module name and an unneeded return.

I strongly disagree.

The only segment which has some merit is the one which replaces the .name
with DRV_NAME. It could have been "usb-block" or something, but we probably
won't be using that, so it's all right.

But the rest is quite bad, the worst being indenting the switch statement.

Is there nothing else you can do in the whole kernel?

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/