Re: [PATCH GIT] drivers/block/ub.c - misc. cleanup/indentation, removed unneeded return

[Marc Koschewski]

* Pete Zaitcev <zaitcev@xxxxxxxxxx> [2006-02-08 19:40:57 -0800]:

> On Wed, 8 Feb 2006 10:29:15 +0100, Marc Koschewski <marc@xxxxxxxxxxxxxxx> wrote:
> 
> > I created this little patch while reading through drivers/block/ub.c. It fixes
> > some indentation/whitespace as well as some empty commenting, an hardcoded
> > module name and an unneeded return.
> 
> I strongly disagree.

OK.

> 
> The only segment which has some merit is the one which replaces the .name
> with DRV_NAME. It could have been "usb-block" or something, but we probably
> won't be using that, so it's all right.

I just dislike using the same values twice and not using constants. More of a
personal thing I guess.

> 
> But the rest is quite bad, the worst being indenting the switch statement.

I see. Why do you use if-statement-indenting then?

What is the sense of the empty comments? What sense does the 'immediate
return' make when the value is returned 2 lines below (where one line is just
a closing brace)?

> 
> Is there nothing else you can do in the whole kernel?

Sure, but I guess you don't have to tell me what files I put my nose in, do
you? I didn't mean to personally piss you off by sending this in. Tzzz ...

Unfortunately my understanding of how ie. the Linux VM works is not very good.
In fact it's poor. But I will dig into this and try to make even you happy with
a patch that makes sense _in your eyes_.

> 
> -- Pete
> 

Marc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/