Re: msync() behaviour broken for MS_ASYNC, revert patch?

From: Andrew Morton
Date: Thu Feb 09 2006 - 22:56:34 EST


Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
> > It's a bit of a disaster if you happen to msync(MS_ASYNC) the same page at
> > any sort of frequency - we have to wait for the previous I/O to complete
> > before new I/O can be started. That was the main problem which caused this
> > change to be made. You can see that it'd make 100x or 1000x speed improvements
> > with some sane access patterns.
> >
>
> I'm not sure you'd have to do that, would you? Just move the dirty bit
> from the pte and skip the page if it is found locked or writeback.

That would make MS_ASYNC mean "start I/O now, unless there's I/O in
progress, in whch case start I/O in 30 seconds. That's not good.

If we're going to change the kernel, better off using fadvise()
enhancements, whic are also useful for post-write() operations.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/