Re: [PATCH] mm: Implement Swap Prefetching v23

[Con Kolivas]

On Friday 10 February 2006 16:32, Nick Piggin wrote:
> Con Kolivas wrote:
> > Just so it's clear I understand, is this what you (both) had in mind?
> > Inline so it's not built for !CONFIG_SWAP_PREFETCH
>
> Close...

> > +inline void lru_cache_add_tail(struct page *page)
>
> Is this inline going to do what you intend?

I don't care if it's actually inlined, but the subtleties of compilers is way 
beyond me. All it positively achieves is silencing the unused function 
warning so I had hoped it meant that function was not built. I tend to be 
wrong though...

>      spin_lock_irq(&zone->lru_lock);
>
> > +	add_page_to_inactive_list_tail(zone, page);
>
>      spin_unlock_irq(&zone->lru_lock);

Thanks!

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/