Re: [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes with pgdat allocation. (Wait table and zonelists initalization)

From: Yasunori Goto
Date: Fri Feb 10 2006 - 23:14:47 EST




> On Fri, 2006-02-10 at 23:20 +0900, Yasunori Goto wrote:
> >
> > static __meminit
> > void zone_wait_table_init(struct zone *zone, unsigned long
> > zone_size_pages)
> > {
> > - int i;
> > + int i, hotadd = (system_state == SYSTEM_RUNNING);
> > struct pglist_data *pgdat = zone->zone_pgdat;
> > + unsigned long allocsize;
> >
> > /*
> > * The per-page waitqueue mechanism uses hashed waitqueues
> > * per zone.
> > */
> > + if (hotadd && (zone_size_pages == PAGES_PER_SECTION))
> > + zone_size_pages = PAGES_PER_SECTION << 2;
>
> I don't think I understand this calculation. You online only 4 sections
> worth of pages?

Ummmmm.
I realized that I've forgotten many things about this patch
due to long time keeping in storage.
At least here looks strange indeed.
I need shake my brain to recall it. :-(


--
Yasunori Goto



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/