Re: [ck] Re: [PATCH] mm: Implement Swap Prefetching v24

[Con Kolivas]

On Saturday 11 February 2006 12:48, Con Kolivas wrote:
> On Saturday 11 February 2006 03:47, Con Kolivas wrote:
> > Try again. Tackled everything I could think of mentioned and more.
>
> Hrm BUG..
>
> This version appears to work fine with the pages being added to the tail of
> the LRU, however there's a problem with the custom lru_cache_add_tail
> function. I end up hitting a bug at:
> 	if (!TestClearPageLRU(page))
> 		BUG();
>
> in isolate_lru_pages called from shrink_zone, find_busiest_group,
> shrink_slab... ultimately from kswapd.

I've been unable to get this one working without reliably BUGging there. As 
soon as anything is prefetched, the next time ram is full it will BUG. So 
I've hacked a lru_cache_add_tail using a variation of the current 
lru_cache_add that uses pagevecs and it has been working flawlessly. I'll 
thrash this implementation around a bit more to see if it breaks and unless 
someone can suggest what I've done wrong with v24 I'll be posting v25 with 
the pagevecs version.

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/