Re: [PATCH 08/13] hrtimer: remove data field

[Ingo Molnar]

* Roman Zippel <zippel@xxxxxxxxxxxxxx> wrote:

> The nanosleep cleanup allows to remove the data field of hrtimer. The 
> callback function can use container_of() to get it's own data. Since 
> the hrtimer structure is usually embedded in other structures, the 
> code also becomes a bit simpler.

i addressed this when you first raised this issue (back in the ktimers 
flamewars), and generally the feeling of people i asked was that doing 
the container_of() approach is less readable than an explicit 'data' 
field. It also deviates from struct timer_list, which we wanted to stay 
close to. Furthermore, for standalone hrtimers this creates the need to 
generate a wrapper structure. So i dont really like this change - but no 
strong feelings either way.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/