Re: RFC: Compact Flash True IDE Mode Driver

[Bartlomiej Zolnierkiewicz]

On 2/13/06, Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:

> > > +static void cfide_outsl(unsigned long port, void *addr, u32 count)
> > > +{
> > > +       panic("outsl unsupported");
> > > +}
> >
> > This will panic as soon as somebody tries to enable 32-bit I/O
> > using hdparm.  Please add ide_hwif_t.no_io_32bit flag and teach
> > ide-disk.c:ide_disk_setup() about it (separate patch).
>
> I'm not sure I follow this, can you expand.

Do "hdparm -c 2 /dev/hdx" first and then read/write to the device
and you should see it. :)

We need to make "hdparm -c 2" (and "hdparm -c 3") unsupported
(see how "io_32bit" setting is handled in ide_add_generic_settings()
and how it can be read-only or read-write setting depending on the
value of drive->no_io_32bit).

To do this we need to set drive->no_io_32bit to 1 (see how
ide_disk_setup() handles it).  Unfortunately 32-bit I/O capability
is based on capabilities of both host and device so we have to
add new flag hwif->no_io_32bit to indicate that host doesn't
support 32-bit I/O.

> > > +static ide_hwif_t *cfide_locate_hwif(void __iomem * base, void __iomem * ctrl,
> > > +                                    unsigned int sz, int irq)
> >
> > __devinit
> >
> > > +{
> > > +       unsigned long port = (unsigned long)base;
> > > +       ide_hwif_t *hwif;
> > > +       int index, i;
> > > +
> > > +       for (index = 0; index < MAX_HWIFS; ++index) {
> > > +               hwif = ide_hwifs + index;
> > > +               if (hwif->io_ports[IDE_DATA_OFFSET] == port)
> > > +                       goto found;
> > > +       }
> > > +
> > > +       for (index = 0; index < MAX_HWIFS; ++index) {
> > > +               hwif = ide_hwifs + index;
> > > +               if (hwif->io_ports[IDE_DATA_OFFSET] == 0)
> > > +                       goto found;
> > > +       }
> > > +
> > > +       return NULL;
> >
> > This is the same as in icside.c/rapide.c,
> > it really should be generic helper (separate patch)
>
> Suggesitions, on where that should live, ide-probe.c?

ide.c, no rush for this one as I have patch ready
(only needs to find it... sigh...)

> > Otherwise driver looks pretty decent and with the above changes
> > it gets my ACK.  Additional enhancements as suggested by Ben
> > would be nice but obviously they are not needed for a start
>
> Everything else makes sense and I'll make those changes, plus some based
> on Ben's comments.  If you can let me know about the two questions
> (expanding on ide_hwif_t.no_io_32bit and where to but a generic version of
> cfide_locate_hwif).

Thanks,
Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/