Re: sb_bread & bforget

[Andrew Morton]

Joshua Hudson <joshudson@xxxxxxxxx> wrote:
>
> New filesystem is using BTrees for directories. An update will touch
> multiple blocks, loaded into buffer_head structures with sb_bread.
> 
> If update fails (only possible causes are read error & disk full), is it
> kosher to call bforget on all modified buffer_head structures, or
> does that have some unintended consequences?

It's probably wrong.  bforget() will clear the dirty bit, so you'd lose
anything else which had been written to that buffer but not written back.

bforget() is used for truncate, where we know the data is being tosed away.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/