Re: [RFC][PATCH] map multiple blocks at a time in mpage_readpages()
Date: Tue Feb 14 2006 - 14:25:19 EST
On Tue, Feb 14, 2006 at 09:49:07AM -0800, Badari Pulavarty wrote:
> I re-did the support for mpage_readpages() to map multiple blocks
> at a time (basically, get_blocks()). Instead of adding new
> get_blocks() and pass it around, I use "bh->b_size" to indicate
> how much of disk mapping we are interested in to get_block().
> This way no changes existing interfaces and no new routines need.
> Filesystem can choose to ignore the passed in "bh->b_size" value
> and map one block at a time (ext2, reiser3, etc..)
Hmm. Given that we only use buffer_heads for page-cache backed I/O
bh->b_size should always be set properly and this would be fine.
If we could completely get rid of ->get_blocks that be a nice cleanup
in all the fs drivers. OTOH I still wonder whether ->get_block should
use a small structure that just contains the information needed with
easy to decipher names..
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/