Re: [PATCH, RFC] [1/3] Generic in-kernel AC status

From: Thomas Renninger
Date: Wed Feb 15 2006 - 10:02:40 EST


Matthew Garrett wrote:
On Wed, Feb 15, 2006 at 01:36:59PM +0100, Thomas Renninger wrote:

Maybe I oversaw an issue, but I really don't see a reason for connecting
the brightness to ac in kernel space.

The backlight class maintainer specified that /sys/../brightness should
Who's that? Is there more info/spec available?
return the *current* brightness. In some cases that's impossible without knowing the ac status.

Ok.
The ac/battery status is used to guess the current brightness? Please
do not set suggested values automatically, IMO this is not a nice feature...
I am really looking forward to see a general /sys/../brightness.
Thanks a lot for working on this!
Just an idea for later:
Beside min/max there probably should be a /sys/../brightness_bat and /sys/../brightness_ac.
- If ac/battery brightness will not be set by kernel, userspace can write the
right value to /sys/../brightness and the above two can be readonly.
- If ac/battery brightness will be set by kernel the above two should even be
writeable so that people can avoid the need of pressing "brightness up"
button without hacking the kernel.

I vote for letting userspace doing the stuff..., e.g. changing brightness behind
the back of some userspace tool will result in userspace tools starting to
poll.

Comments?

Thomas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/