Re: [PATCH 0/1] swsusp: fix breakage with swap on LVM

From: Pavel Machek
Date: Sat Feb 18 2006 - 10:58:49 EST


On Thu 16-02-06 23:41:16, Rafael J. Wysocki wrote:
> On Thursday 16 February 2006 22:51, Rafael J. Wysocki wrote:
> > On Thursday 16 February 2006 17:13, Pavel Machek wrote:
> > > -rc3 version looks ok, and we probably want it in asap. -mm
> > > version looks a bit long... --p
> >
> > That's because it adds a new function + comment.
> >
> > I think it's not a good idea to remake mm/swapfile.c:swap_type_of()
> > in a -rc3-like fashion, because it is called by the userland interface for
> > a different purpose and should not return non-error for the argument
> > being zero.
>
> Well, alternatively I can change the userland interface. :-)

ACK.


--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/