Re: Flames over -- Re: Which is simpler?

[Pavel Machek]

On So 18-02-06 11:34:17, Phillip Susi wrote:
> Pavel Machek wrote:
> >You are missing this. In 1st case, no data is actually lost, because of
> >sync in suspend code;
> >while second case is "goodbye, filesystem".
> 
> Provided that you sync before suspending, and there are no open files on 
> the filesystem, then yes, no data will be lost.  If there are open files 
> on the fs, such as a half saved document, or a running binary, or say, 
> the whole root fs, then you're going to loose data and even panic the 
> kernel, sync or no sync.  From the user perspective, this is
>unacceptable.

While with your solution, you do not loose one open file, you loose
whole filesystem. Which is unacceptable.

> Why should the user give up such functionality just because the 
> connection to the drive thy are using is USB?  Every other type of drive 
> and interface does not suffer from this problem.

Because it is okay to unplug usb disk on runtime, while it is not okay
to unplug ATA disk on runtime. And because alternatives suck even more.

> Maybe Linux should take a page from windows' playbook here.  I believe 
> windows handles this scenario with a USB drive the same way it does when 
> you eject a floppy and reinsert it.  The driver detects that the 
> media/drive _may_ have changed and so it fails requests from the 
> filesystem with an error code indicating this.  The filesystem then sets 
> an override flag so it can send down some reads to verify the media. 
> Generally the FS reads the super block and compares it with the in 
> memory one to make sure it appears to be the same media, and if so, 
> continues normal access without data loss.

Feel free to implement that.
								Pavel

-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/